Skip to content

chore: Control params via URL query in async property filter demo #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jperals wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Control params via URL query in async property filter demo #4120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions pages/property-filter/async-loading.integ.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ type PropertyFilterDemoContext = React.Context<
AppContextType<{
token: string;
asyncProperties: boolean;
pageSize: number;
delay: number;
items: number;
}>
>;

Expand All @@ -26,10 +29,6 @@ const filteringProperties = [
groupValuesLabel: `Label values`,
},
] as const;
const filteringOptions = range(1000).map(value => ({
propertyKey: 'property',
value: value + '',
}));

interface ExtendedWindow {
loadItemsCalls: PropertyFilterProps.LoadItemsDetail[];
Expand All @@ -39,6 +38,12 @@ window.loadItemsCalls = [];

export default function () {
const { urlParams } = useContext(AppContext as PropertyFilterDemoContext);

const filteringOptions = range(urlParams.items ?? 1000).map(value => ({
propertyKey: 'property',
value: value + '',
}));

const [query, setQuery] = useState<PropertyFilterProps['query']>({
tokens: [
urlParams.token === 'freeText'
Expand All @@ -48,8 +53,8 @@ export default function () {
operation: 'and',
});
const [fetchTarget, setFetchTarget] = useState<'properties' | 'options'>('properties');
const propertiesLoader = useOptionsLoader({ timeout: 100 });
const optionsLoader = useOptionsLoader<PropertyFilterProps.FilteringOption>({ pageSize: 100, timeout: 100 });
const propertiesLoader = useOptionsLoader({ pageSize: urlParams.pageSize ?? 25, timeout: urlParams.delay ?? 100 });
const optionsLoader = useOptionsLoader<PropertyFilterProps.FilteringOption>({ pageSize: 10, timeout: 1000 });
const status = { properties: propertiesLoader, options: optionsLoader }[fetchTarget].status;

const handleLoadItems = ({ detail }: { detail: PropertyFilterProps.LoadItemsDetail }) => {
Expand Down Expand Up @@ -79,7 +84,7 @@ export default function () {
return (
<>
<h1>Integration tests fixture for async loading suggestions</h1>
<ScreenshotArea disableAnimations={true}>
<ScreenshotArea>
<PropertyFilter
{...labels}
i18nStrings={i18nStrings}
Expand Down
Loading