fix: Memoize context provider values #4143
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This branch includes #4142, which should be merged first. Submitting the changes separately would cause merge conflicts.
Description
When the
valueobject in a context provider changes, every component that consumes that context is updated. That means that something as simple ascan create unnecessary updates: If the provider re-renders but
xis the same, all context consumers will nonetheless update because a new{x}object is produced.This PR adds memoization to all context providers to reduce unnecessary updates. This could have significant performance benefits in tables, where
WidthsContexthas been causingTheadto update even when no column widths changed.How has this been tested?
Existing test coverage should be sufficient for this change.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.