feat(CENG-636): Change OIDC default audience#26
Merged
BartoszBlizniak merged 2 commits intomasterfrom Dec 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the default OIDC audience from api://AzureADTokenExchange to https://github.com/{org-name} (using the GITHUB_REPOSITORY_OWNER environment variable) to improve security through organization-specific audience claims.
Key Changes:
- Modified the default OIDC audience logic to dynamically construct the audience URL based on the repository owner
- Updated documentation across README, action.yml, and CHANGELOG to reflect the breaking change
- Changed the default parameter value from a hardcoded string to an empty string with fallback logic in the implementation
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main.js | Implements new fallback logic for OIDC audience using GITHUB_REPOSITORY_OWNER environment variable |
| src/oidc-auth.js | Changes default parameter from 'api://AzureADTokenExchange' to empty string |
| dist/index.js | Compiled version with same changes as source files |
| action.yml | Updates input description and default value to reflect new dynamic default |
| README.md | Documents breaking change with clear migration guidance in a dedicated notices section |
| CHANGELOG.md | Records breaking change in version 2.0.0 with explanation of impact |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
opswithranjan
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
api://AzureADTokenExchangetohttps://github.com/{org-name}(usingGITHUB_REPOSITORY_OWNER) for better security. Users relying on the old value must update their configuration or explicitly set the previous audience if needed.Documentation and configuration updates:
README.mdandaction.ymlfiles have been updated to clearly document the new default for the OIDC audience. Theoidc-audienceinput description now explains the dynamic default and how to override it.