v0.7.0: update client dependency + all APIs #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New API changes the tunnel stream setup process to avoid awaiting each new tunnel and focus on WebSocket-based transports. SPDY metadata is still in place but there are currently no SPDY client transports offered, with hopes that Kubernetes will improve its offering for PodPortForward over WebSocket and we can stop talking about SPDY.
Since tunnel setup is more synchronous, we are actually establishing the streams before the WebSocket handshake completes (because if we wait, we'll receive the initial packets before we have destinations for them) So things like conditional behavior off the handshaked protocol version must be done lazily, while port forward setup must be done immediately for websockets (and only websockets). Not really looking forward to reconciling this code for whenever Kubernetes introduces a better way to do port forwards over WebSocket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cloudydeno/kubernetes-clientdependency to latest (v0.8.0)changed and aren't compatible between
v0.7andv0.8.In this case you must update these libraries together for Typescript to be happy.
argo-cdandcert-managerCRDs.