Hearts of Iron IV support#397
Open
CommandGenius wants to merge 11 commits into
Open
Conversation
Contributor
Author
|
I gotta remove the debug stuff first |
There was a problem hiding this comment.
Pull request overview
Adds a new Hearts of Iron IV (HOI4) game module to the RenoDX codebase, including shader injection and a small integration point to drive the external “RenoDXHelper” effect based on the UI nits setting.
Changes:
- Added HOI4 add-on entry point (
addon.cpp) wiring up shader + swapchain mods and enabling RenoDXHelper integration. - Introduced HOI4 shader injection definitions (
shared.h) and a new pixel shader replacement implementing RenoDX tonemapping/intermediate passes. - Extended the shared settings overlay/utilities to enable/disable RenoDXHelper and push
RENODX_UI_NITSwhen presets/settings change.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/utils/settings.hpp |
Adds RenoDXHelper update logic and an event hook to apply the helper once and on relevant setting changes. |
src/games/hoi4/shared.h |
Defines HOI4 shader injection constant buffer layout and maps it into RenoDX shader includes. |
src/games/hoi4/output_0xB99B4F78.ps_5_0.hlsl |
Adds the HOI4 pixel shader replacement with RenoDX tonemap + intermediate rendering integration. |
src/games/hoi4/addon.cpp |
New HOI4 module wiring for shader/swapchain mods and settings, including enabling RenoDXHelper usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .format = "%.2f", \ | ||
| } | ||
|
|
||
| bool useRenoDXHelper = false; |
Comment on lines
+1
to
+2
| #ifndef SRC_TEMPLATE_SHARED_H_ | ||
| #define SRC_TEMPLATE_SHARED_H_ |
| } // namespace | ||
|
|
||
| extern "C" __declspec(dllexport) constexpr const char* NAME = "RenoDX"; | ||
| extern "C" __declspec(dllexport) constexpr const char* DESCRIPTION = "RenoDX (Generic)"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires RenoDXHelper