Skip to content

VNC workaround for debug compile failure #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nagyrobi wants to merge 1 commit into
base: remote_display
Choose a base branch
from
Open

VNC workaround for debug compile failure #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion esphome/components/vnc/vnc_display.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@
tv.tv_usec = 1000;
// this->client_sock_->setblocking(false);
this->client_sock_->setsockopt(SOL_SOCKET, SO_RCVTIMEO, &tv, sizeof(tv));
esph_log_d(TAG, "Accepted %s", this->client_sock_->getpeername().c_str());
// esph_log_d(TAG, "Accepted %s", this->client_sock_->getpeername().c_str()); //
int err = this->write_(RFB_MAGIC, sizeof RFB_MAGIC);
if (err < 0)
this->disconnect_();
Expand Down Expand Up @@ -403,7 +403,7 @@

void set_state_(ClientState state) {
this->state_ = state;
ESP_LOGD(TAG, "Set state to %s", state_names[state]);

Check failure on line 406 in esphome/components/vnc/vnc_display.h

View workflow job for this annotation

GitHub Actions / Run script/ci-custom 

Found reference to ESP_LOG in header file. Using ESP_LOG* in header files is currently not possible - please move the definition to a source file (.cpp)
}
void tx_16(uint16_t value) {
put16_be(this->tx_buf_ + this->tx_buflen_, value);
Expand Down
Loading