Fixes based on observations during v2605 anaTuple production #243
Merged
Conversation
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14733800 started |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates FLAF’s anaTuple production workflow based on v2605 observations by adding a run token server to rate-limit job starts (reducing AFS load), improving anaTuple file list / merge-plan creation (including run-aware merging for data), skipping empty nanoAOD inputs, and extending DY dataset coverage with LO DY samples in the 10–50 GeV mass window.
Changes:
- Added a TCP token server + client and integrated it into HTCondor job bootstrap to throttle job starts per analysis path.
- Reworked anaTuple merge planning to be run-aware for data (emit per-item
runsand apply run filtering during merge) and enhanced file list creation (skip unavailable/empty inputs). - Added LO DY (10 < m_ll < 50 GeV) dataset entries across Run3 eras and updated dataset exception patterns.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
test/test_run_token_server.py |
Adds a small client script to smoke-test the token server protocol. |
test/hello_world_task.py |
Adds a minimal LAW task for basic workflow testing. |
run_tools/run_token_server.py |
Implements the TCP token server that rate-limits tokens per path. |
run_tools/law_customizations.py |
Wires token-server settings into HTCondor job rendering and ships the token client script with jobs. |
run_tools/get_run_token.py |
Implements the token client used by bootstrap.sh before sourcing the environment. |
bootstrap.sh |
Requests a run token before sourcing env.sh to reduce AFS stampede effects. |
AnaProd/tasks.py |
Skips empty nanoAOD files; updates merge-plan creation call; propagates runs into merge step. |
AnaProd/MergeAnaTuples.py |
Applies a per-merge-item run filter for data before duplicate-event filtering. |
AnaProd/AnaTupleFileList.py |
Re-implements file clustering and merge schema planning, including run-aware contamination avoidance for data. |
config/Run3_2024/datasets.yaml |
Adds LO DY 10–50 samples (per-flavor) for Run3_2024. |
config/Run3_2023BPix/datasets.yaml |
Adds LO DY 10–50 sample for Run3_2023BPix. |
config/Run3_2023/datasets.yaml |
Adds LO DY 10–50 sample for Run3_2023. |
config/Run3_2022EE/datasets.yaml |
Adds LO DY 10–50 sample for Run3_2022EE. |
config/Run3_2022/datasets.yaml |
Adds LO DY 10–50 sample for Run3_2022. |
config/dataset_exceptions.yaml |
Extends dataset consistency exceptions for the new DY LO samples. |
config/law.cfg |
Registers the test.hello_world_task module with LAW. |
Collaborator
|
pipeline#14733800 failed |
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#14734901 started |
Collaborator
|
pipeline#14734901 failed |
Collaborator
|
pipeline#14734901 passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.