con33-c new NCCE/CS - #75
Open
sei-dsvoboda wants to merge 13 commits into
Open
Conversation
sei-jsible
requested changes
Jul 7, 2026
sei-jsible
requested changes
Jul 8, 2026
sei-jsible
requested changes
Jul 10, 2026
sei-jsible
left a comment
sei-jsible
left a comment
Contributor
There was a problem hiding this comment.
I also feel like this example has gotten too convoluted and unclear what it's supposed to be doing. Perhaps instead, the example should just be two different threads tokenizing two unrelated strings.
| if (mtx_unlock(&lock) == thrd_error) { | ||
| return -1; /* Indicate error to caller */ | ||
| } | ||
| return t[0]; |
Contributor
There was a problem hiding this comment.
This seems like a bad example, since if str could vary instead of being hardcoded, then this could potentially be a NULL dereference.
Contributor
Author
There was a problem hiding this comment.
I've changed str from a string literal to argv[1] and made sure it exists. So it cannot be NULL.
Contributor
There was a problem hiding this comment.
t can be NULL even if str isn't, because the string might have run out of tokens already.
Contributor
Author
There was a problem hiding this comment.
I added null checks before each t[0].
Contributor
There was a problem hiding this comment.
Are you sure they pushed successfully? I don't see them still.
sei-jsible
requested changes
Jul 10, 2026
sei-jsible
requested changes
Jul 17, 2026
Comment on lines
165
to
167
| </p></td><td><p>A sequence of calls of the strtok function is made from different threads (7.26.5.9). | ||
| </p></td><td><p><a href="/sei-cert-c-coding-standard/rules/concurrency-con/con33-c">CON33-C</a></p></td></tr> | ||
| </p></td></tr><tr class="even"><td><div class="content-wrapper"><p>200 <a id="CC.UndefinedBehavior-ub_200"></a></p></div></td><td><p><img src="images/icons/emoticons/warning.svg" /></p></td><td><p>The first argument in the very first call to the <code> strtok </code> or <code> wcstok </code> is a null pointer (7.26.5.9, 7.31.4.5.8).</p></td><td><p><br /> |
Contributor
There was a problem hiding this comment.
Suggested change
| </p></td><td><p>A sequence of calls of the strtok function is made from different threads (7.26.5.9). | |
| </p></td><td><p><a href="/sei-cert-c-coding-standard/rules/concurrency-con/con33-c">CON33-C</a></p></td></tr> | |
| </p></td></tr><tr class="even"><td><div class="content-wrapper"><p>200 <a id="CC.UndefinedBehavior-ub_200"></a></p></div></td><td><p><img src="images/icons/emoticons/warning.svg" /></p></td><td><p>The first argument in the very first call to the <code> strtok </code> or <code> wcstok </code> is a null pointer (7.26.5.9, 7.31.4.5.8).</p></td><td><p><br /> | |
| </p></td><td><p>A sequence of calls of the strtok function is made from different threads (7.26.5.9).</p></td><td><p><a href="/sei-cert-c-coding-standard/rules/concurrency-con/con33-c">CON33-C</a></p></td></tr><tr class="even"><td><div class="content-wrapper"><p>200 <a id="CC.UndefinedBehavior-ub_200"></a></p></div></td><td><p><img src="images/icons/emoticons/warning.svg" /></p></td><td><p>The first argument in the very first call to the <code> strtok </code> or <code> wcstok </code> is a null pointer (7.26.5.9, 7.31.4.5.8).</p></td><td><p><br /> |
Contributor
There was a problem hiding this comment.
It looks like you did something similar to this, but there's still two </p></td></tr>s immediately in a row (end of 170 and beginning of 171).
…on/05.con33-c.md Co-authored-by: sei-jsible <105077289+sei-jsible@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.