Disable judges' game panel buttons if required inputs aren't set.

[timparenti]

Specifically, "start game" and "set flags" buttons.

Resolves #15.

[timparenti]

Some amount of form validation can probably come out of postForm() with this change, as well. Feel free to ask me to tackle that, or to tackle it yourself, @michaelfelixmurphy.

[michaelfelixmurphy]

This looks fine, but my only concern is that, if the button is disabled, there's no indication why. I thought about this because of course now we could remove the requirement checking code from postForm(), because we can never trigger it - but then we'll never show the required error message - so you have no way of knowing why the button is disabled. I can't think of an easy solution for this at the moment. Maybe it's not that big of a problem.

[timparenti]

I'll keep thinking on it this week, then. Initial thought is a combination of:

• A tooltip on the button whenever it's disabled, and
• The existing error stylization in postForm() being moved into some sort of "if you try to click it anyway" function.

Let's keep this open while I iterate on that work, since that kinda goes hand-in-hand.

[michaelfelixmurphy]

Sounds good. There’s definitely a way to put a bootstrap tooltip on a disabled button, but it’s a bit gross because you have to wrap the button in something not disabled. I’ll poke at it when I have time, but that will probably be a few weeks. After today I’m not letting myself work on this for a bit because it’s been taking too much time and I need to prepare for a trip this weekend.

…

On Mar 4, 2019, at 04:40, Tim Parenti ***@***.***> wrote: I'll keep thinking on in this week, then. Initial thought is a combination of: A tooltip on the button whenever it's disabled, and The existing error stylization in postForm() being moved into some sort of "if you try to click it anyway" function. Let's keep this open for that work, since that kinda goes hand-in-hand. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.