Restore Manual Torque Scaling for 100Hz source (#180)#191
Restore Manual Torque Scaling for 100Hz source (#180)#191google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
This commit addresses Issue #180 by providing a toggle to enable/disable session-learned Dynamic Normalization for the 100Hz Steering Shaft Torque source. Key changes: - Added 'm_dynamic_normalization_enabled' to FFBEngine and Config systems. - Updated calculate_force to use 'm_wheelbase_max_nm' as a fixed Nm reference when dynamic normalization is disabled for the 100Hz source. - Added a UI checkbox in the General FFB section with a descriptive tooltip. - Ensured thread safety for UI updates using 'g_engine_mutex'. - Added a new regression test 'tests/test_ffb_normalization_toggle.cpp'. - Updated version to 0.7.80 and documented in changelogs. This fix also mitigates Issue #175 by preventing "limp" steering after high-torque spikes when dynamic normalization is disabled.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Restore Manual Torque Scaling for 100Hz source (#180) and mitigate Issue #175.
Implemented a toggle for dynamic normalization, updated physics logic, added UI controls, and verified with a new regression test.
PR created automatically by Jules for task 5740787879625897380 started by @coasting-nc