Fix soft lock should work when the car is stationary as well #184#232
Fix soft lock should work when the car is stationary as well #184#232google-labs-jules[bot] wants to merge 3 commits intomainfrom
Conversation
- Removed explicit force zeroing in main.cpp when not in realtime. - Enhanced GameConnector heartbeat to include steering input changes. - Added comprehensive unit tests for Soft Lock preservation and heartbeat logic. - Updated VERSION to 0.7.118 and added CHANGELOG entry.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
- Removed explicit force zeroing in main.cpp when not in realtime. - Enhanced GameConnector heartbeat to include steering input changes. - Reset heartbeat state on disconnect to ensure test isolation. - Fixed unit test mock initialization for reliable heartbeat verification. - Updated VERSION to 0.7.118 and synchronized CHANGELOG.
- Removed explicit force zeroing in main.cpp when not in realtime. - Enhanced GameConnector heartbeat to include steering input changes. - Reset heartbeat state on disconnect to ensure test isolation. - Fixed unit test mock initialization and background thread interference. - Updated VERSION to 0.7.118 and synchronized CHANGELOG.
1 participant
This PR resolves Issue #184 by ensuring that steering Soft Lock remains active even when the game is paused or in menus.
Key changes:
if (!in_realtime) force = 0.0;override inmain.cpp. TheFFBEnginealready correctly handles the!allowedstate by muting all physics/vibration effects while preserving the Soft Lock force.GameConnectorto treat steering input changes as a "freshness" signal. This prevents telemetry from being marked as "stale" when simulation time is frozen (game paused), allowing the FFB loop to continue processing Soft Lock as the user moves the wheel.full_allowedlogic ensures that no other FFB effects (bumps, engine vibration, etc.) are active in menus, maintaining the intended safety fix for Issue if the ffb is interrupted(menu,or back to garage) the wheel keeps punching to left or right side and dont stop until u are back in the car #174.Verified on Linux with mock Shared Memory and dedicated unit tests in
tests/test_issue_184_softlock.cpp.PR created automatically by Jules for task 1833263049804993893 started by @coasting-nc