Skip to content

🎨 Palette: Improve Preset Management UX#409

Open
google-labs-jules[bot] wants to merge 1 commit intomainfrom
palette-ux-preset-improvements-15566027926526011534
Open

🎨 Palette: Improve Preset Management UX#409
google-labs-jules[bot] wants to merge 1 commit intomainfrom
palette-ux-preset-improvements-15566027926526011534

Conversation

@google-labs-jules
Copy link
Contributor

I have implemented several micro-UX improvements in the 'Presets and Configuration' section of the lmuFFB GUI:

  1. Clearer Input Field: The "New Preset Name" field now uses InputTextWithHint, displaying "Enter Name..." as a placeholder when empty, which guides the user better.
  2. Input Validation: The "Save New" button is now visually disabled if no name has been entered, preventing clicks that don't produce any action and giving clear feedback on the required input.
  3. Destructive Action Protection: Deleting a preset now triggers a confirmation modal ("Confirm Delete?"). This prevents accidental deletions. The "Delete" button inside the modal is highlighted in red to signal its destructive nature, following standard UI/UX safety patterns.
  4. Regression Testing: Added a new unit test file tests/test_palette_ux.cpp that exercises these new UI logic paths, ensuring the code works as expected and doesn't crash.

These changes make the preset management more intuitive, safer, and pleasant to use.


PR created automatically by Jules for task 15566027926526011534 started by @coasting-nc

- Replace standard InputText for new preset name with InputTextWithHint for clearer instruction ("Enter Name...").
- Disable "Save New" button when the name input field is empty to provide better visual feedback.
- Add a red-styled confirmation modal for the "Delete" action to prevent accidental data loss.
- Include a new regression test suite `tests/test_palette_ux.cpp` to verify the enhancements.
- Update `tests/CMakeLists.txt` and `tests/main_test_runner.cpp` to include the new test.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant