Skip to content

GardenerNodeLifecycleController: add timeout for HA-disabled wait#268

Draft
fwiesel wants to merge 1 commit intomainfrom
offboarding-ha-disabling-optional
Draft

GardenerNodeLifecycleController: add timeout for HA-disabled wait#268
fwiesel wants to merge 1 commit intomainfrom
offboarding-ha-disabling-optional

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Mar 16, 2026

When a node is terminating and offboarded, the controller waits for HaEnabled=False before allowing pod eviction. Previously it would wait indefinitely; now it times out after HaDisabledTimeout (default 15m), measured from the Offboarded condition's LastTransitionTime, so a stalled HA controller cannot block node termination indefinitely.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 54f1bd99-d54a-455a-b3d3-218db5ee4e4e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch offboarding-ha-disabling-optional
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@fwiesel
Copy link
Contributor Author

fwiesel commented Mar 16, 2026

Draft, as untested.

When a node is terminating and offboarded, the controller waits for
HaEnabled=False before allowing pod eviction. Previously it would wait
indefinitely; now it times out after HaDisabledTimeout (default 15m),
measured from the Offboarded condition's LastTransitionTime, so a
stalled HA controller cannot block node termination indefinitely.
@fwiesel fwiesel force-pushed the offboarding-ha-disabling-optional branch from bbb19f6 to b07c31d Compare March 17, 2026 12:58
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 63.63% (+0.54%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller.go 77.61% (+6.18%) 67 (+11) 52 (+12) 15 (-1) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant