GardenerNodeLifecycleController: add timeout for HA-disabled wait#268
GardenerNodeLifecycleController: add timeout for HA-disabled wait#268
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
Draft, as untested. |
When a node is terminating and offboarded, the controller waits for HaEnabled=False before allowing pod eviction. Previously it would wait indefinitely; now it times out after HaDisabledTimeout (default 15m), measured from the Offboarded condition's LastTransitionTime, so a stalled HA controller cannot block node termination indefinitely.
bbb19f6 to
b07c31d
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
When a node is terminating and offboarded, the controller waits for HaEnabled=False before allowing pod eviction. Previously it would wait indefinitely; now it times out after HaDisabledTimeout (default 15m), measured from the Offboarded condition's LastTransitionTime, so a stalled HA controller cannot block node termination indefinitely.