Skip to content

[Makefile] Fix make install-crds#273

Open
notandy wants to merge 1 commit intomainfrom
fix-install-crds-makefile
Open

[Makefile] Fix make install-crds#273
notandy wants to merge 1 commit intomainfrom
fix-install-crds-makefile

Conversation

@notandy
Copy link
Contributor

@notandy notandy commented Mar 19, 2026

Summary by CodeRabbit

Chores

  • Updated CRD installation to source manifests from a new directory location for better organization with Helm charts.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

The install-crds targets in build configuration files have been updated to reference CRD manifests from the Helm chart directory (charts/openstack-hypervisor-operator/crds/*.yaml) instead of the legacy configuration directory (config/crd/*.yaml).

Changes

Cohort / File(s) Summary
CRD Installation Path Update
Makefile, Makefile.maker.yaml
Updated install-crds target kubectl apply paths from config/crd/*.yaml to charts/openstack-hypervisor-operator/crds/*.yaml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hops through the charts with glee,
CRDs now in their rightful tree,
From config/crd to helm's embrace,
Fresh paths guide our Kubernetes space!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the install-crds Makefile target by updating its CRD path from config/crd to charts/openstack-hypervisor-operator/crds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-install-crds-makefile
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Makefile.maker.yaml`:
- Line 76: The quoted glob in the kubectl apply command prevents shell
expansion; update the command string kubectl apply -f
"charts/openstack-hypervisor-operator/crds/*.yaml" to remove the quotes so the
shell can expand the *.yaml files before kubectl sees them, and make the
identical change where the same quoted glob exists in the Makefile (noted at
Makefile:38).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5fe5aef9-6e42-4a76-b327-1ba456e29108

📥 Commits

Reviewing files that changed from the base of the PR and between 0c09786 and edd55d9.

📒 Files selected for processing (2)
  • Makefile
  • Makefile.maker.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant