Add CRLF frontmatter regression tests for loop-sync - #489
Open
shaurya703 wants to merge 1 commit into
Open
Conversation
- Cover LF frontmatter (existing behaviour), CRLF frontmatter parsing keys/values without trailing \r, and rejection of an opening fence with no newline (---hello) - Export extractFrontmatter so the regression tests can exercise it directly - Rebuild dist, which was stale relative to the src fix from cobusgreyling#476 Fixes cobusgreyling#479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #479
Adds regression tests for
extractFrontmatterintools/loop-sync, locking in the CRLF fix from #476:---\r\nkey: value\r\n---\r\nbody) parses keys and values without trailing\r---hello(no newline after the opening fence) is rejected: empty frontmatter, body returned unchangedNotes:
extractFrontmatterwas module-private, so it is now exported fromsrc/sync.tsto let the tests exercise it directly.dist/sync.jswas stale relative to thesrc/sync.tsfix from fix(loop-sync): handle CRLF frontmatter correctly #476 (it still had the pre-fixstartsWith('---')logic), sodistis rebuilt in this PR. Without the rebuild, the---hellorejection test fails against the committed dist.Suite results (
cd tools/loop-sync && npm test): 10 tests, 10 pass, 0 fail.