Skip to content

Conversation

@rail
Copy link
Member

@rail rail commented Dec 5, 2025

Backport 1/1 commits from #158903 on behalf of @rail.


Fixes: CRDB-45643
Release note: none


Release justification: readme update

@rail rail force-pushed the blathers/backport-release-23.1-158903 branch from cea32fb to 32b7a27 Compare December 5, 2025 22:10
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 5, 2025
@blathers-crl blathers-crl bot requested review from celiala and jlinder December 5, 2025 22:10
@blathers-crl
Copy link

blathers-crl bot commented Dec 5, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-code-systems labels Dec 5, 2025
@blathers-crl
Copy link

blathers-crl bot commented Dec 5, 2025

❌ PR #158926 does not comply with backport policy

Confidence: high
Explanation: The pull request involves a change to README.md, which is not a non-production file under the specified non-production file patterns. Furthermore, the PR does not meet the critical bug criteria as outlined in the CockroachDB Backport Policy. The change is described as a 'readme update' and thus does not relate to any stability, security issues, data corruption/loss, significant performance regressions, incorrect database results, or improvements in debugging capabilities. Additionally, there are no indications of this change being gated behind a feature flag or involving new cluster settings which are disabled by default. Therefore, as this change does not qualify under the critical bug fix or feature flag requirements, it is non-compliant. Also, the release justification provided ('readme update') does not justify a bypass of the backport criteria. Lastly, there is no evidence suggesting that this change would cause backward compatibility issues.
Recommendation: Reconsider the backport or provide a more substantial justification for backporting this change.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Fixes: CRDB-45643
Release note: none
@rail rail force-pushed the blathers/backport-release-23.1-158903 branch from 32b7a27 to bcd9474 Compare December 7, 2025 17:13
@rail rail closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-code-systems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants