cli: attach postgresql:// scheme if not provided to encode-uri#160202
Closed
kev-cao wants to merge 1 commit intocockroachdb:masterfrom
Closed
cli: attach postgresql:// scheme if not provided to encode-uri#160202kev-cao wants to merge 1 commit intocockroachdb:masterfrom
kev-cao wants to merge 1 commit intocockroachdb:masterfrom
Conversation
The `encode-uri` command currently does parse the provided URI as a URI if no scheme is provided. As a consequence, if a string `hostname:26257` is passed, it parses it as a path and no prefix/default root user is attached to the output. If a URL-structure like `hostname.com` is provided, then the scheme is attached with a double ://, resulting in `postgresql://://hostname.com`. Epic: None Release note (cli change): Fixes a bug in the `encode-uri` utility that resulted in faulty encoding of URIs without a scheme. The `postgresql://` scheme is now prefixed to any URIs missing a scheme.
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Contributor
Author
|
Closing in favor of #164561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
encode-uricommand currently does parse the provided URI as a URI if no scheme is provided. As a consequence, if a stringhostname:26257is passed, it parses it as a path and no prefix/default root user is attached to the output.If a URL-structure like
hostname.comis provided, then the scheme is attached with a double ://, resulting inpostgresql://://hostname.com.Epic: None
Release note (cli change): Fixes a bug in the
encode-uriutility that resulted in faulty encoding of URIs without a scheme. Thepostgresql://scheme is now prefixed to any URIs missing a scheme.