Skip to content

Remove Negative Values in changefeed.sink_io_workers#164103

Closed
hegdeadithyak wants to merge 1 commit intocockroachdb:masterfrom
hegdeadithyak:master
Closed

Remove Negative Values in changefeed.sink_io_workers#164103
hegdeadithyak wants to merge 1 commit intocockroachdb:masterfrom
hegdeadithyak:master

Conversation

@hegdeadithyak
Copy link

@hegdeadithyak hegdeadithyak commented Feb 22, 2026

This PR updates the description of changefeed.sink_io_workers to match the actual behavior.
Any value <= 0 (including negative values and 0) now clearly means a default worker count will be chosen automatically, while values > 0 use the given number.

Fixes: #156774

@hegdeadithyak hegdeadithyak requested a review from a team as a code owner February 22, 2026 03:14
@hegdeadithyak hegdeadithyak requested review from aerfrei and removed request for a team February 22, 2026 03:14
@trunk-io
Copy link
Contributor

trunk-io bot commented Feb 22, 2026

Merging to master in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@blathers-crl
Copy link

blathers-crl bot commented Feb 22, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Feb 22, 2026
@cockroachlabs-cla-agent
Copy link

cockroachlabs-cla-agent bot commented Feb 22, 2026

CLA assistant check
All committers have signed the CLA.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aerfrei
Copy link
Contributor

aerfrei commented Feb 23, 2026

This is a good catch and worth merging. Please squash down to one commit and make sure it has a commit message that conforms to the repo's policy.

Copy link
Contributor

@aerfrei aerfrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash and edit the commit message.

@blathers-crl
Copy link

blathers-crl bot commented Mar 1, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link

blathers-crl bot commented Mar 1, 2026

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser.

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@hegdeadithyak
Copy link
Author

Apologies everyone — I believe I made a mistake while squashing the commits. I’ve corrected it now, but I’m not sure why it’s still requesting a review.

@hegdeadithyak hegdeadithyak requested a review from aerfrei March 1, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-community Originated from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CDC's SinkIOWorkers setting does not respect negative values

3 participants