server: resolve TODOEngine in addStore#164555
Open
pav-kv wants to merge 1 commit intocockroachdb:masterfrom
Open
server: resolve TODOEngine in addStore#164555pav-kv wants to merge 1 commit intocockroachdb:masterfrom
pav-kv wants to merge 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Contributor
|
Merging to
|
pav-kv
commented
Feb 27, 2026
Epic: none Release note: none
pav-kv
force-pushed
the
toodengine-addstore
branch
from
5159a08 to
52a735c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register both engines for disk slow and low disk space callbacks. There might be some redundancy when both engines reside on the same FS, but there is no harm in getting this signal / logging twice.
Alternatively, we could register "low disk space" only for one engine (assuming the other one gives a duplicate signal), but that bakes in an assumption that engines are collocated. Err on the side of generality instead.
Part of #97627