importer: fix output type mismatch in distmerge flow planning#165254
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom Mar 9, 2026
Merged
Conversation
Contributor
|
😎 Merged successfully - details. |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
PR cockroachdb#164536 moved SST metadata from the import processor's third output column to the progress metadata channel. PR cockroachdb#164977 updated the processor's own output type declaration (importProcessorOutputTypes) from 3 to 2 columns, but missed the separate output type declaration in import_processor_planning.go used to build the physical plan. This caused the receiver (gateway node) to set up a StreamDecoder expecting 3 columns via InputSyncSpec.ColumnTypes, while the producer sent 2-column rows. When the gateway decoded the row, it panicked with "index out of range [2] with length 2" in StreamDecoder.GetRow, crashing the node. Fix by using importProcessorOutputTypes (the single source of truth) in the flow plan instead of a separate local variable. Fixes: cockroachdb#165147 Epic: CRDB-48845 Release note: None
mw5h
force-pushed
the
mw5h/fix-distmerge-plan-output-types
branch
from
e22b4a0 to
fe74af9
Compare
mw5h
requested review from
spilchen and
yuzefovich
and removed request for
a team
yuzefovich
approved these changes
Mar 9, 2026
Member
yuzefovich
left a comment
yuzefovich
left a comment
There was a problem hiding this comment.
@yuzefovich reviewed 1 file and all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on spilchen).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #164536 moved SST metadata from the import processor's third output
column to the progress metadata channel. PR #164977 updated the
processor's own output type declaration (
importProcessorOutputTypes)from 3 to 2 columns, but missed the separate output type declaration
in
import_processor_planning.goused to build the physical plan.This caused the receiver (gateway node) to set up a
StreamDecoderexpecting 3 columns via
InputSyncSpec.ColumnTypes, while the producersent 2-column rows. When the gateway decoded the row, it panicked with
index out of range [2] with length 2inStreamDecoder.GetRow,crashing the node.
Fix by using
importProcessorOutputTypes(the single source of truth)in the flow plan instead of a separate local variable.
Fixes: #165147
Epic: CRDB-48845
Release note: None