main: add -formatonly flag to avoid go toolchain dependency#58
Merged
Conversation
Previously, crlfmt's default path ran goimports with import resolution enabled, which shells out to the go toolchain (`go env`, `go list`) to add missing and remove unused imports. This made a go toolchain a runtime requirement; without `go` on `$PATH`, crlfmt failed with "go command required, not found". This adds a `-formatonly` flag that sets goimports' `FormatOnly` option, which skips import resolution. With the flag, crlfmt still applies gofmt formatting, the simplify pass, signature wrapping, and import grouping, but no longer requires the go toolchain. The trade-off is that missing imports are not added and unused imports are not removed, since that resolution fundamentally needs the module graph. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
rail
approved these changes
Jun 10, 2026
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, crlfmt's default path ran goimports with import resolution
enabled, which shells out to the go toolchain (
go env,go list) toadd missing and remove unused imports. This made a go toolchain a
runtime requirement; without
goon$PATH, crlfmt failed with"go command required, not found".
This adds a
-formatonlyflag that sets goimports'FormatOnlyoption,which skips import resolution. With the flag, crlfmt still applies gofmt
formatting, the simplify pass, signature wrapping, and import grouping,
but no longer requires the go toolchain. The trade-off is that missing
imports are not added and unused imports are not removed, since that
resolution fundamentally needs the module graph.
Co-Authored-By: roachdev-claude roachdev-claude-bot@cockroachlabs.com