Add options to expand empty tags and to skip line breaks #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey, thanks for the PR :) |
Owner
|
Release v0.5.4 is available with your options :) |
dobo90
added a commit
to dobo90/playready-rs
that referenced
this pull request
Feb 10, 2025
cocool97/xml-builder#14 was merged and released as 0.5.4.
|
I think this should have resulted in a bump to the minor version? As-is, Cargo will happily resolve the version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing playready-rs, it came out that Microsoft server doesn't accept XML with empty tags (like
<emptytag />) - they need to be expanded to<emptytag></emptytag>.Moreover parts of XML content are signed. When signed content contains new line characters, server also doesn't accept the payload.
Thanks for the great crate! Is it possible to review those changes and if they are acceptable to merge them? I would love to publish playready-rs on crates.io (but it's not possible as I'm using patched xml-builder).