Skip to content

generate meta tags update#6

Merged
AlemTuzlak merged 6 commits intomainfrom
metadata-update
May 13, 2025
Merged

generate meta tags update#6
AlemTuzlak merged 6 commits intomainfrom
metadata-update

Conversation

@abrulic
Copy link
Copy Markdown
Contributor

@abrulic abrulic commented May 12, 2025

Description

  • removed keywords
  • added twitterCard property
  • og:* tags use property instead name

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

@abrulic abrulic marked this pull request as draft May 12, 2025 11:26
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 100% (🎯 80%) 928 / 928
🟢 Statements 100% (🎯 80%) 928 / 928
🟢 Functions 100% (🎯 80%) 35 / 35
🟢 Branches 100% (🎯 80%) 132 / 132
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/remix/metadata.ts 100% 100% 100% 100%
Generated in workflow #10 for commit 28bc97a by the Vitest Coverage Report Action

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented May 12, 2025

Open in StackBlitz

npm i https://pkg.pr.new/forge-42/seo-tools/@forge42/seo-tools@6

commit: 28bc97a

@abrulic abrulic requested a review from thomasfr May 12, 2025 11:39
@abrulic abrulic marked this pull request as ready for review May 12, 2025 11:39
package.json Outdated
{
"name": "@forge42/seo-tools",
"version": "1.3.0",
"version": "1.3.1",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ok?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should bump at least the minor, since it removes and changes some things.

package.json Outdated
{
"name": "@forge42/seo-tools",
"version": "1.3.0",
"version": "1.3.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should bump at least the minor, since it removes and changes some things.

@AlemTuzlak AlemTuzlak merged commit d52718e into main May 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants