Open
Conversation
__splitBufDataAndCreateDataHeader__ dataListLen should multiply self.channel
Owner
|
I think it is not only the channel problem. Maybe it is about the bit_depth. Maybe we should multiplied block_align or bit_depth/8. That needs to be tested. |
Owner
|
No need to multiplied self.channel, in design every channel is the same sound,so we just need one channel to use, two channel will have repeat cut file, if you think two channel have different data, you can change it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the splitBufDataAndCreateDataHeader method, dataListLen needs to be multiplied by self.channel; otherwise, the audio length in the header will be incorrect.