Update reference submission to handle all batch sizes#26
Open
Lance-Bai wants to merge 7 commits into
Open
Conversation
Collaborator
|
Can you please add a README file for the submission, explaining what it does and how it achieves security like here https://github.com/fhe-benchmarking/fetch-by-similarity/tree/main/submission? Also, can you also please push the measurements folder? |
code-perspective
approved these changes
Jun 22, 2026
code-perspective
left a comment
code-perspective
left a comment
Owner
There was a problem hiding this comment.
Thanks for cleaning all the binaries.
Looks good. Minor nits.
| if num_chunks != 8 { | ||
| return Err("expected 8 chunks of 16 bits".into()); | ||
| } | ||
| // if num_chunks != 8 { |
Owner
There was a problem hiding this comment.
Maybe remove commented out code.
| println!("Transciphering keys saved to {}", ciphertext_upload_dir); | ||
| } else { | ||
| return Err(Box::from(format!("Unexpected size {}", size))); | ||
| } |
Owner
There was a problem hiding this comment.
How about adding an else block for error handling?
else {
return Err(Box::from(format!("Unexpected size {}", size)));
}
andreea-alexandru
requested changes
Jun 25, 2026
andreea-alexandru
left a comment
andreea-alexandru
left a comment
Collaborator
There was a problem hiding this comment.
Could you please resolve these comments made in the PR, so that we have a clean base to address the rest of the issues without conflicts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commands work with ./harness/run_submission 1 and ./harness/run_submission 2 is avaliable