Fix stars pill 404 for logged-out visitors#121
Closed
devswha wants to merge 1 commit into
Closed
Conversation
GitHub now returns 404 on /stargazers for anonymous visitors (reproducible even on facebook/react/stargazers), so the landing page stars pill and the README badge dead-end for logged-out users. Point both at the repo page, where the star button lives.
Contributor
|
Thanks for the PR! Changes to LazyCodex land through oh-my-openagent — could you open this against omo-codex over there instead? PRs in this repository can't be merged. If you're working with a coding agent, prompt it like this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GitHub stars pill on lazycodex.ai links to
https://github.com/code-yeongyu/lazycodex/stargazers. GitHub now returns 404 on/stargazersfor logged-out visitors — reproducible even onfacebook/react/stargazers— so the most prominent CTA on the landing page dead-ends for anonymous visitors. Easy to miss while logged in, since the page works fine for authenticated users.Verified in a headless browser (logged out):
github.com/code-yeongyu/lazycodex/stargazersgithub.com/facebook/react/stargazersgithub.com/code-yeongyu/lazycodexFix
packages/web/lib/site-config.ts— pointgithubStarsUrlat the repo page, where the star button lives anyway.packages/web/e2e/landing.spec.ts— update the test name to match (assertion logic unchanged; it readsSITE_CONFIG.githubStarsUrl).README.md— the stars badge had the same/stargazerslink.Verification
Ran locally in
packages/web:pnpm run type-check— passpnpm run lint— passpnpm run test:e2e— 59 passed (3.1m), including the stars pill link + live API tests and both Lighthouse 100/100/100/100 presetsNote on the PR routing workflow
I'm aware
pr-source-guidance.ymlauto-closes PRs here and points tooh-my-openagent/packages/omo-codex— butpackages/web(the lazycodex.ai source) only exists in this repository, and the sync script in oh-my-openagent copies only the marketplace/plugin and the workflow file. Website fixes currently have no valid upstream PR path, so opening here; happy to re-file wherever you prefer.Summary by cubic
Point the landing page stars pill to the repo page instead of /stargazers to avoid GitHub’s 404 for logged-out visitors. Also updates the README badge and the e2e test to match.
Written for commit b7bb6d1. Summary will update on new commits.