Return value of environment's variable called "ZXPCMD" if exists#14
Open
Lilipi wants to merge 1 commit intocodearoni:masterfrom
Open
Return value of environment's variable called "ZXPCMD" if exists#14Lilipi wants to merge 1 commit intocodearoni:masterfrom
Lilipi wants to merge 1 commit intocodearoni:masterfrom
Conversation
Owner
|
This violates the existing API. It would require a 2.0.0, and I'm not a fan of the nature of the change. I would rather have something like require('zxp-provider').env return an environment path, or null. Giving the user the ability to fallback to .bin or something else. |
Author
|
Hello, |
Lilipi
force-pushed
the
feature/envVariable
branch
from
199a435 to
63a7869
Compare
Author
|
PR updated as suggested. Thanks |
Lilipi
force-pushed
the
feature/envVariable
branch
from
63a7869 to
a57f143
Compare
…e called ZXPCMD if exists
Lilipi
force-pushed
the
feature/envVariable
branch
2 times, most recently
from
6db6d44 to
cfb82ff
Compare
Author
|
Hi @codearoni, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, works as before