Skip to content

Conversation

@devAgam
Copy link

@devAgam devAgam commented May 29, 2021

No description provided.

Copy link

@pedenys pedenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add the .env file to gitignore. Usually Next.js projects use .env.local for development purposes (docs).

The .env file here is similar to a env.sample where it's only here to show which variables are to fill.

@devAgam
Copy link
Author

devAgam commented Oct 15, 2021

I suppose we could change the file name from .env to .env.example or .env.sample to avoid any possible confusion for someone new to envs or someone coming from dotenv in node

@codebycorey
Copy link
Owner

Hey @devAgam Thank you for the contribution. I was following the standard practice for Next.js. There should be comments in the .env file that explicitly says do not commit secrets to this file.

Maybe it should be renamed to env.sample like @pedenys suggested, reducing confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants