Conversation
|
Thanks a lot @mlincoln4 I will prepare for 1.9.4 release. |
| resemble.outputSettings({ | ||
| boundingBox: options.boundingBox, | ||
| ignoredBox: options.ignoredBox, | ||
| boundingBoxes: options.boundingBoxes, |
There was a problem hiding this comment.
@mlincoln4 this change is probably going to impact https://github.com/codeceptjs/codeceptjs-resemblehelper/blob/master/index.js#L379 could you please make sure it works as expected
There was a problem hiding this comment.
see where we set the boundingBox option,
codeceptjs-resemblehelper/index.js
Line 322 in 1cc3b60
There was a problem hiding this comment.
Well that is checking the visual difference for an element, in which case I don't think bounding boxes need to be supported since you are already specifying an element for the bounds. I am not sure though. That part isn't as important to me, I just happened to notice the plural ones weren't currently supported.
My boss sent you the following email:
We are currently working on a project using the resemble helper and have been trying to find a good way to get the mismatch percentage of a pair of images without triggering a failure. When looking in the codeceptjs-resemblehelper/index.js file I found that there is a function that does exactly that, _fetchMisMatchPercentage(). However, in order to be able to use this function, I have had to remove the underscore from the beginning of the name. Would it be possible to update this so that function can be exposed?
Also a side-note, it seems that in the _compareImages() function, the options only handle boundingBox/ignoredBox and not boundingBoxes/ignoredBoxes:
Could this also possibly be updated?
I have made the small changes in this pull request. Let me know if you have any problems with it. Thanks a lot!