Skip to content

Renamed the Codedx to SRM#3

Merged
splahoti12 merged 9 commits intomasterfrom
renaming/codedx-to-srm
Sep 23, 2025
Merged

Renamed the Codedx to SRM#3
splahoti12 merged 9 commits intomasterfrom
renaming/codedx-to-srm

Conversation

@splahoti12
Copy link

Renaming the codedx to SRM
Jira :- https://blackduck.atlassian.net/browse/CDX-4387

@splahoti12 splahoti12 requested a review from RyanMcC September 15, 2025 18:28
Copy link

@RyanMcC RyanMcC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments, there are some other changes that should be made:

  • javahelp/org/zaproxy/zap/extension/codedx should be renamed to javahelp/org/zaproxy/zap/extension/srm
  • The changes made to javahelp/org/zaproxy/zap/extension/codedx/resources/help should be applied to the other languages as well. I know we discussed skipping changes for the content, but at a minimum the file names (codedx.html, codedx.png) and names/IDs used in the various config files (index.xml, map.jhm, toc.xml) should be updated. I'd say it would also be good to at least find/replace Code Dx with Software Risk Manager for helpset_....hs and codedx.html as well. If Code Dx has been translated for that language, I'd say don't worry about trying to update it.
  • The Messages_....properties for other languages should be updated to use the correct IDs. e.g. like srm.topmenu.upload.title instead of codedx.topmenu.upload.title. Like with codedx.html, you may as well find/replace Code Dx -> Software Risk Manager too, since most of them still have that. I'd say don't worry about any that have translated Code Dx though.

@splahoti12
Copy link
Author

splahoti12 commented Sep 18, 2025

In addition to the comments, there are some other changes that should be made:

  • javahelp/org/zaproxy/zap/extension/codedx should be renamed to javahelp/org/zaproxy/zap/extension/srm
  • The changes made to javahelp/org/zaproxy/zap/extension/codedx/resources/help should be applied to the other languages as well. I know we discussed skipping changes for the content, but at a minimum the file names (codedx.html, codedx.png) and names/IDs used in the various config files (index.xml, map.jhm, toc.xml) should be updated. I'd say it would also be good to at least find/replace Code Dx with Software Risk Manager for helpset_....hs and codedx.html as well. If Code Dx has been translated for that language, I'd say don't worry about trying to update it.
  • The Messages_....properties for other languages should be updated to use the correct IDs. e.g. like srm.topmenu.upload.title instead of codedx.topmenu.upload.title. Like with codedx.html, you may as well find/replace Code Dx -> Software Risk Manager too, since most of them still have that. I'd say don't worry about any that have translated Code Dx though.

Okay sure will updating the help_ar_SA this kinds of folder also as i think its generated automatically if we changed the help folder... same with the message.properties

One more thing this codeDxApiKey also have to rename to srmApiKey?
as in the SrmAPI class i am still using
private static final String ACTION_PARAM_API_KEY = "codeDxApiKey";

@splahoti12 splahoti12 requested a review from RyanMcC September 18, 2025 14:20
Copy link

@RyanMcC RyanMcC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • codedx.html needs to be renamed to srm.html in help_fr_FR and help_id_ID
  • Code Dx is still present in help_it_IT/toc.xml
  • You should probably add srm.error.required = The Server URL and API Key are required. to the other non-English Messages_*.properties files. You don't need to try translating it, just add it as-is. I'm not sure what happens if a code isn't available for a given language. If it doesn't fall back to Messages.properties and either throws an exception or has a generic placeholder, we need to avoid that.

I know that normally this stuff would be more or less automatically handled and things generated for the non-English docs/messages, but afaik we don't have anything to handle that on this fork. The ZAP repo does this via a bot that pulls changes from Crowdin, but we don't have that set up here.

@splahoti12 splahoti12 requested a review from RyanMcC September 23, 2025 19:20
@splahoti12 splahoti12 merged commit 61e19b6 into master Sep 23, 2025
2 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants