Conversation
RyanMcC
left a comment
There was a problem hiding this comment.
In addition to the comments, there are some other changes that should be made:
javahelp/org/zaproxy/zap/extension/codedxshould be renamed tojavahelp/org/zaproxy/zap/extension/srm- The changes made to
javahelp/org/zaproxy/zap/extension/codedx/resources/helpshould be applied to the other languages as well. I know we discussed skipping changes for the content, but at a minimum the file names (codedx.html,codedx.png) and names/IDs used in the various config files (index.xml,map.jhm,toc.xml) should be updated. I'd say it would also be good to at least find/replaceCode DxwithSoftware Risk Managerforhelpset_....hsandcodedx.htmlas well. IfCode Dxhas been translated for that language, I'd say don't worry about trying to update it. - The
Messages_....propertiesfor other languages should be updated to use the correct IDs. e.g. likesrm.topmenu.upload.titleinstead ofcodedx.topmenu.upload.title. Like withcodedx.html, you may as well find/replaceCode Dx->Software Risk Managertoo, since most of them still have that. I'd say don't worry about any that have translatedCode Dxthough.
addOns/srm/src/main/java/org/zaproxy/zap/extension/srm/SrmExtension.java
Outdated
Show resolved
Hide resolved
addOns/srm/src/main/java/org/zaproxy/zap/extension/srm/SrmExtension.java
Outdated
Show resolved
Hide resolved
addOns/srm/src/main/java/org/zaproxy/zap/extension/srm/SrmProperties.java
Show resolved
Hide resolved
addOns/srm/src/main/java/org/zaproxy/zap/extension/srm/UploadPropertiesDialog.java
Outdated
Show resolved
Hide resolved
addOns/srm/src/main/java/org/zaproxy/zap/extension/srm/UploadPropertiesDialog.java
Outdated
Show resolved
Hide resolved
Okay sure will updating the help_ar_SA this kinds of folder also as i think its generated automatically if we changed the help folder... same with the message.properties One more thing this codeDxApiKey also have to rename to srmApiKey? |
There was a problem hiding this comment.
codedx.htmlneeds to be renamed tosrm.htmlinhelp_fr_FRandhelp_id_IDCode Dxis still present inhelp_it_IT/toc.xml- You should probably add
srm.error.required = The Server URL and API Key are required.to the other non-EnglishMessages_*.propertiesfiles. You don't need to try translating it, just add it as-is. I'm not sure what happens if a code isn't available for a given language. If it doesn't fall back toMessages.propertiesand either throws an exception or has a generic placeholder, we need to avoid that.
I know that normally this stuff would be more or less automatically handled and things generated for the non-English docs/messages, but afaik we don't have anything to handle that on this fork. The ZAP repo does this via a bot that pulls changes from Crowdin, but we don't have that set up here.
…o renaming/codedx-to-srm
Renaming the codedx to SRM
Jira :- https://blackduck.atlassian.net/browse/CDX-4387