Skip to content

Commit 0e2f57e

Browse files
committed
lower threshold and cleanup comments
1 parent dd2c5cd commit 0e2f57e

File tree

4 files changed

+3
-6
lines changed

4 files changed

+3
-6
lines changed

.github/workflows/e2e-futurehouse-structure.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
COLUMNS: 110
2525
MAX_RETRIES: 3
2626
RETRY_DELAY: 5
27-
EXPECTED_IMPROVEMENT_PCT: 10
27+
EXPECTED_IMPROVEMENT_PCT: 5
2828
CODEFLASH_END_TO_END: 1
2929
steps:
3030
- name: 🛎️ Checkout

codeflash/optimization/function_optimizer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1615,7 +1615,7 @@ def establish_original_code_baseline(
16151615
test_files=self.test_files,
16161616
optimization_iteration=0,
16171617
testing_time=total_looping_time,
1618-
enable_coverage=True, # Always enable coverage with pytest
1618+
enable_coverage=True,
16191619
code_context=code_context,
16201620
)
16211621
finally:

tests/scripts/end_to_end_test_futurehouse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def run_test(expected_improvement_pct: int) -> bool:
88
config = TestConfig(
99
file_path="src/aviary/common_tags.py",
1010
expected_unit_tests=1,
11-
min_improvement_x=0.1,
11+
min_improvement_x=0.05,
1212
coverage_expectations=[
1313
CoverageExpectation(
1414
function_name="find_common_tags",

tests/scripts/end_to_end_test_utilities.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ def run_codeflash_command(
8585

8686
path_to_file = cwd / config.file_path
8787
file_contents = path_to_file.read_text("utf-8")
88-
# Check if tests/pytest exists, otherwise use tests/ directly
8988
pytest_dir = cwd / "tests" / "pytest"
9089
test_root = pytest_dir if pytest_dir.is_dir() else cwd / "tests"
9190

@@ -130,7 +129,6 @@ def build_command(
130129

131130
if config.function_name:
132131
base_command.extend(["--function", config.function_name])
133-
# Always use pytest - test framework is specified via tests-root and module-root
134132
base_command.extend(["--tests-root", str(test_root), "--module-root", str(cwd)])
135133
if benchmarks_root:
136134
base_command.extend(["--benchmark", "--benchmarks-root", str(benchmarks_root)])
@@ -189,7 +187,6 @@ def validate_stdout_in_candidate(stdout: str, expected_in_stdout: list[str]) ->
189187

190188

191189
def run_trace_test(cwd: pathlib.Path, config: TestConfig, expected_improvement_pct: int) -> bool:
192-
# Check if tests/pytest exists, otherwise use tests/ directly
193190
pytest_dir = cwd / "tests" / "pytest"
194191
test_root = pytest_dir if pytest_dir.is_dir() else cwd / "tests"
195192
clear_directory(test_root)

0 commit comments

Comments
 (0)