Skip to content

[FIX] incorrect PR message shown when --no-pr flag is passed #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohammedahmed18 merged 1 commit into from
Dec 8, 2025
Merged

[FIX] incorrect PR message shown when --no-pr flag is passed #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions codeflash/discovery/functions_to_optimize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
)
from codeflash.code_utils.env_utils import get_pr_number
from codeflash.code_utils.git_utils import get_git_diff, get_repo_owner_and_name
from codeflash.code_utils.time_utils import humanize_runtime
from codeflash.discovery.discover_unit_tests import discover_unit_tests
from codeflash.lsp.helpers import is_LSP_enabled
from codeflash.models.models import FunctionParent
Expand Down Expand Up @@ -244,13 +243,6 @@ def get_functions_to_optimize(
)

logger.info(f"!lsp|Found {functions_count} function{'s' if functions_count > 1 else ''} to optimize")
if optimize_all:
three_min_in_ns = int(1.8e11)
console.rule()
logger.info(
f"It might take about {humanize_runtime(functions_count * three_min_in_ns)} to fully optimize this project. Codeflash "
f"will keep opening pull requests as it finds optimizations."
)
return filtered_modified_functions, functions_count, trace_file_path


Expand Down
11 changes: 11 additions & 0 deletions codeflash/optimization/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
create_worktree_snapshot_commit,
remove_worktree,
)
from codeflash.code_utils.time_utils import humanize_runtime
from codeflash.either import is_successful
from codeflash.models.models import ValidCode
from codeflash.telemetry.posthog_cf import ph
Expand Down Expand Up @@ -270,6 +271,16 @@ def run(self) -> None:

function_optimizer = None
file_to_funcs_to_optimize, num_optimizable_functions, trace_file_path = self.get_optimizable_functions()
if self.args.all:
three_min_in_ns = int(1.8e11)
console.rule()
pr_message = (
"\nCodeflash will keep opening pull requests as it finds optimizations." if not self.args.no_pr else ""
)
logger.info(
f"It might take about {humanize_runtime(num_optimizable_functions * three_min_in_ns)} to fully optimize this project.{pr_message}"
)

function_benchmark_timings, total_benchmark_timings = self.run_benchmarks(
file_to_funcs_to_optimize, num_optimizable_functions
)
Expand Down
Loading