Skip to content

⚡️ Speed up function _format_variables by 21% #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _format_variables by 21% #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions marimo/_server/ai/prompts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,22 @@ def _format_variables(
if not variables:
return ""

variable_info = "\n\n## Available variables from other cells:\n"
# Use a list for efficient string concatenation
lines = ["\n\n## Available variables from other cells:\n"]
append = lines.append # local variable for faster access

for variable in variables:
if isinstance(variable, VariableContext):
if _is_private_variable := variable.name.startswith("_"):
if variable.name.startswith("_"):
continue
variable_info += f"- variable: `{variable.name}`\n"
variable_info += f" - value_type: {variable.value_type}\n"
variable_info += f" - value_preview: {variable.preview_value}\n"
append(f"- variable: `{variable.name}`\n")
append(f" - value_type: {variable.value_type}\n")
append(f" - value_preview: {variable.preview_value}\n")
else:
if _is_private_variable := variable.startswith("_"):
if variable.startswith("_"):
continue
variable_info += f"- variable: `{variable}`"

return variable_info
append(f"- variable: `{variable}`")
return "".join(lines)


def _rules(rules: list[str]) -> str:
Expand Down