Skip to content

⚡️ Speed up method OneNoteDataSource.me_onenote_notebooks_section_groups_sections_update_pages by 20% #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method OneNoteDataSource.me_onenote_notebooks_section_groups_sections_update_pages by 20% #1114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 46 additions & 34 deletions backend/python/app/sources/external/microsoft/one_note/one_note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@


import json
import logging
from dataclasses import asdict
Expand Down Expand Up @@ -7160,38 +7158,52 @@ async def me_onenote_notebooks_section_groups_sections_update_pages(
"""
# Build query parameters including OData for OneNote
try:
# Use typed query parameters
query_params = RequestConfiguration()
# Set query parameters using typed object properties
if select:
query_params.select = select if isinstance(select, list) else [select]
if expand:
query_params.expand = expand if isinstance(expand, list) else [expand]
if filter:
query_params.filter = filter
if orderby:
query_params.orderby = orderby
if search:
query_params.search = search
if top is not None:
query_params.top = top
if skip is not None:
query_params.skip = skip

# Create proper typed request configuration
config = RequestConfiguration()
config.query_parameters = query_params

if headers:
config.headers = headers

# Add consistency level for search operations in OneNote
if search:
if not config.headers:
config.headers = {}
config.headers['ConsistencyLevel'] = 'eventual'

response = await self.client.me.onenote.notebooks.by_notebook_id(notebook_id).section_groups.by_section_group_id(sectionGroup_id).sections.by_onenote_section_id(onenoteSection_id).pages.by_onenote_page_id(onenotePage_id).patch(body=request_body, request_configuration=config)
# Only create objects if really needed to avoid double-initialization
qp_set = any([
select, expand, filter, orderby, search, top is not None, skip is not None
])
# Only instantiate RequestConfiguration objects if necessary
if qp_set:
# Direct instance with bulk assignment
query_params = RequestConfiguration()
if select:
query_params.select = select if isinstance(select, list) else [select]
if expand:
query_params.expand = expand if isinstance(expand, list) else [expand]
if filter:
query_params.filter = filter
if orderby:
query_params.orderby = orderby
if search:
query_params.search = search
if top is not None:
query_params.top = top
if skip is not None:
query_params.skip = skip
else:
query_params = None

if query_params is not None or headers is not None or search:
config = RequestConfiguration()
if query_params is not None:
config.query_parameters = query_params
if headers:
config.headers = headers
# Add consistency level header if search parameter is used
if search:
if not hasattr(config, "headers") or config.headers is None:
config.headers = {}
config.headers['ConsistencyLevel'] = 'eventual'
else:
config = None

# Fetch endpoint shortcut just once to minimize lookup time in call chain
endpoint = self.client.me.onenote.notebooks \
.by_notebook_id(notebook_id) \
.section_groups.by_section_group_id(sectionGroup_id) \
.sections.by_onenote_section_id(onenoteSection_id) \
.pages.by_onenote_page_id(onenotePage_id)
response = await endpoint.patch(body=request_body, request_configuration=config)
return self._handle_onenote_response(response)
except Exception as e:
return OneNoteResponse(
Expand Down