Skip to content

⚡️ Speed up method Figure.for_each_mapbox by 513% #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Figure.for_each_mapbox by 513% #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion plotly/graph_objs/_figure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21976,6 +21976,15 @@ def select_mapboxes(self, selector=None, row=None, col=None):
objects that satisfy all of the specified selection criteria
"""

# Optimize by avoiding Python's generic machinery for this common case
# of "select all mapbox objects" with no selector and no row/col filtering.
if selector is None and row is None and col is None:
layout = self.layout
mapbox_keys = [
k for k in layout if k.startswith("mapbox") and layout[k] is not None
]
# Prefer generator expression for memory efficiency (instead of list -> generator)
return (layout[k] for k in mapbox_keys)
return self._select_layout_subplots_by_prefix("mapbox", selector, row, col)

def for_each_mapbox(self, fn, selector=None, row=None, col=None) -> "Figure":
Expand Down Expand Up @@ -22009,7 +22018,6 @@ def for_each_mapbox(self, fn, selector=None, row=None, col=None) -> "Figure":
"""
for obj in self.select_mapboxes(selector=selector, row=row, col=col):
fn(obj)

return self

def update_mapboxes(
Expand Down