Skip to content

⚡️ Speed up function _py_to_js by 53% #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _py_to_js by 53% #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions plotly/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,18 @@ def _py_to_js(v, widget_manager):
Value that the ipywidget library can serialize natively
"""

# Handle Undefined
# ----------------
if v is Undefined:
return "_undefined_"

# Fast path for simple types
elif type(v) in (str, int, float, bool) or v is None:
return v

# Handle dict recursively
# -----------------------
if isinstance(v, dict):
elif isinstance(v, dict):
return {k: _py_to_js(v, widget_manager) for k, v in v.items()}

# Handle list/tuple recursively
Expand All @@ -53,11 +62,6 @@ def _py_to_js(v, widget_manager):
# Convert all other numpy arrays to lists
return v.tolist()

# Handle Undefined
# ----------------
if v is Undefined:
return "_undefined_"

# Handle simple value
# -------------------
else:
Expand Down