Skip to content

⚡️ Speed up function is_text_element by 190% #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −14
Open

⚡️ Speed up function is_text_element by 190% #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions unstructured/partition/html/transformations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@
ONTOLOGY_CLASS_TO_UNSTRUCTURED_ELEMENT_TYPE,
)

text_classes = (
ontology.NarrativeText,
ontology.Quote,
ontology.Paragraph,
ontology.Footnote,
ontology.FootnoteReference,
ontology.Citation,
ontology.Bibliography,
ontology.Glossary,
)

text_categories = (ontology.ElementTypeEnum.metadata,)

RECURSION_LIMIT = 50


Expand Down Expand Up @@ -186,22 +199,10 @@ def can_unstructured_elements_be_merged(
def is_text_element(ontology_element: ontology.OntologyElement) -> bool:
"""Categories or classes that we want to combine with inline text"""

text_classes = [
ontology.NarrativeText,
ontology.Quote,
ontology.Paragraph,
ontology.Footnote,
ontology.FootnoteReference,
ontology.Citation,
ontology.Bibliography,
ontology.Glossary,
]
text_categories = [ontology.ElementTypeEnum.metadata]

if any(isinstance(ontology_element, class_) for class_ in text_classes):
if isinstance(ontology_element, text_classes):
return True

return any(ontology_element.elementType == category for category in text_categories)
return ontology_element.elementType == text_categories[0]


def is_inline_element(ontology_element: ontology.OntologyElement) -> bool:
Expand Down