Save update prefix statement to statement history#484
Conversation
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
|
👋 A new build is available for this PR based on 868009f. |
sebjulliand
left a comment
There was a problem hiding this comment.
Works as advertised; nice addition 👍🏻
Merge whenever you want.
forstie
left a comment
There was a problem hiding this comment.
While its absolutely correct that the UPDATE now appears in the statement history, the users requesting this support are going to expect to see a little bit more.
Can you consider adding the parameter marker values as comments?
UPDATE toystore.sales t SET t.SALES = ? WHERE SALES_ID = ?;
|
@forstie Turns out there was logic to do exactly that in the bind stuff. I just had to make use of it! Can you give it a try again now with the updated VSIX? 1.mp4 |
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
|
@SanjulaGanepola As for the re-test, I tried loading the vsix (https://github.com/codefori/vscode-db2i/actions/runs/21038335027) twice and in both cases it told me that the UDTF: prefix was unrecognized. Since you've already confirmed the support, lets just integrate and move on. |
This PR adds the executed update statement to the
Statement Historyview. Note that the?markers are kept as is. This is consistent with how the currentbindprefix adds to the history.Fixes #462