Skip to content

Save update prefix statement to statement history#484

Merged
sebjulliand merged 2 commits intomainfrom
feature/save-update-to-history
Jan 15, 2026
Merged

Save update prefix statement to statement history#484
sebjulliand merged 2 commits intomainfrom
feature/save-update-to-history

Conversation

@SanjulaGanepola
Copy link
Member

This PR adds the executed update statement to the Statement History view. Note that the ? markers are kept as is. This is consistent with how the current bind prefix adds to the history.

Fixes #462

image

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola changed the title Save update prefix statement to query history Save update prefix statement to statement history Jan 14, 2026
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

👋 A new build is available for this PR based on 868009f.

@SanjulaGanepola SanjulaGanepola requested a review from a team January 14, 2026 22:32
Copy link
Member

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised; nice addition 👍🏻
Merge whenever you want.

Copy link
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While its absolutely correct that the UPDATE now appears in the statement history, the users requesting this support are going to expect to see a little bit more.
Can you consider adding the parameter marker values as comments?

UPDATE toystore.sales t SET t.SALES = ? WHERE SALES_ID = ?;

@SanjulaGanepola
Copy link
Member Author

@forstie Turns out there was logic to do exactly that in the bind stuff. I just had to make use of it! Can you give it a try again now with the updated VSIX?

1.mp4

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@forstie
Copy link
Collaborator

forstie commented Jan 15, 2026

@SanjulaGanepola
Outstanding and you even captured a movie. Nice.

As for the re-test, I tried loading the vsix (https://github.com/codefori/vscode-db2i/actions/runs/21038335027) twice and in both cases it told me that the UDTF: prefix was unrecognized.

Since you've already confirmed the support, lets just integrate and move on.
Great going!

Copy link
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible

@sebjulliand sebjulliand merged commit f0146b6 into main Jan 15, 2026
1 check passed
@sebjulliand sebjulliand deleted the feature/save-update-to-history branch January 15, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update prefix suggestion

3 participants