Fix single character empty cells not being updatable#486
Merged
sebjulliand merged 2 commits intomainfrom Jan 15, 2026
Merged
Conversation
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
|
👋 A new build is available for this PR based on 2e05fe9. |
Collaborator
forstie
requested changes
Jan 15, 2026
Collaborator
forstie
left a comment
There was a problem hiding this comment.
This is improved for sure.
That said, I posted an issue that I'm seeing in the comments.
Please take a look.
Thanks
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #463
The original fix in 14b0c6b, did not properly handle updating of single character empty cells. This new fix removes browser-inserted
<br>tags due to empty contenteditable divs.Before


The update statement previously used to have a random line break:
After running the update a second time, you were able to edit it, but the preview of the update statement was not correct:
After


No more line breaks:
Can properly update a single character empty cell on the first try: