Skip to content

Fix single character empty cells not being updatable#486

Merged
sebjulliand merged 2 commits intomainfrom
fix/single-char-update
Jan 15, 2026
Merged

Fix single character empty cells not being updatable#486
sebjulliand merged 2 commits intomainfrom
fix/single-char-update

Conversation

@SanjulaGanepola
Copy link
Member

Fixes #463

The original fix in 14b0c6b, did not properly handle updating of single character empty cells. This new fix removes browser-inserted <br> tags due to empty contenteditable divs.

image

Before
The update statement previously used to have a random line break:
image
After running the update a second time, you were able to edit it, but the preview of the update statement was not correct:
image

After
No more line breaks:
image
Can properly update a single character empty cell on the first try:
image

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola requested review from a team and forstie January 15, 2026 03:31
@github-actions
Copy link

github-actions bot commented Jan 15, 2026

👋 A new build is available for this PR based on 2e05fe9.

@forstie
Copy link
Collaborator

forstie commented Jan 15, 2026

This works better for sure, but while validating, I hit a similar issue.
Can you please take a look?

COMMON1
update: select * from coolstuff.singletons;

It doesn't allow me to update the highlighted cells.
image

Copy link
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is improved for sure.
That said, I posted an issue that I'm seeing in the comments.
Please take a look.
Thanks

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola
Copy link
Member Author

@forstie I merged into this branch the changes on the main branch which will pull in what was added in #409. I gave the scenario you mentioned a try and it works now. Can you try the updated VSIX?

Screenshare.-.2026-01-15.10_44_17.AM.1.mp4

Copy link
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!
Ship it

@sebjulliand sebjulliand merged commit e7b35e4 into main Jan 15, 2026
1 check passed
@sebjulliand sebjulliand deleted the fix/single-char-update branch January 15, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using Update: Option in Run SQL single character fields sometimes cannot be updated

3 participants