Fixed SQLJobManager::endAll() crashing when disconnecting#490
Merged
SanjulaGanepola merged 2 commits intomainfrom Jan 22, 2026
Merged
Fixed SQLJobManager::endAll() crashing when disconnecting#490SanjulaGanepola merged 2 commits intomainfrom
SanjulaGanepola merged 2 commits intomainfrom
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
👋 A new build is available for this PR based on e41d149. |
SanjulaGanepola
requested changes
Jan 21, 2026
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue found by @drahreg while using the exported API.
When disconnecting or when the connection is lost (e.g. the VPN died), the
disconnectevent triggers thedb2i-disconnectcallback that is supposed to clear everything up.The problem is
SQLManager::endAll()gets called at this point, but it fails to close the SQL jobs because the connection is already gone. Since it fails, the internal jobs list and the selected job are not cleared and these values are kept when reconnecting, leading to potential issues afterwards.This PR fixes the issue by adding an optional parameter to
endAll()so it doesn't try to close the jobs if the connection is already gone (the jobs are gone too at this point anyway).