Add search item tooltip#2523
Conversation
|
@chrjorgensen any chance you can fix that conflict? |
|
@worksofliam Done - had to eat first... 😉 |
worksofliam
left a comment
There was a problem hiding this comment.
The change makes sense, but we are going to need test cases for this branch new method. Those belong in content.test.ts.
| * @param path | ||
| * @return IFSFile | ||
| */ | ||
| async getFileInfo(path: string): Promise<IFSFile> { |
There was a problem hiding this comment.
I think we are going to need some new test cases for this method.
There was a problem hiding this comment.
I will add some test cases...
| if (grepRes.code == 0) { | ||
| const hits = parseGrepOutput(grepRes.stdout); | ||
| for (var i = 0; i < hits.length; i++) { | ||
| hits[i].file = await connection.content.getFileInfo(hits[i].path) |
There was a problem hiding this comment.
Has this been testing with a large hits array length? I wonder if getFileInfo might be nicely suited to accept an array as parameter and then call stat with multiple paths? Is that possible?
There was a problem hiding this comment.
It has not been tested, but both stat and ls supports multiple filenames, so I will change the function to accept an array of filenames and return an array of files info.
|
@chrjorgensen Please update this branch with the changes from master, but make sure your fix to |
|
@chrjorgensen would you like me to pick this up? |
Changes
This PR will add tooltips to the items in the search result view:
Members:

Streamfiles:

Streamfiles - find:

Included in the PR is a fix for invalid dates from the
getMemberInfoandgetMultipleMemberInfofunctions...How to test this PR
Examples:
Checklist