Clear cache for any files that reference includes that are changed#470
Open
SanjulaGanepola wants to merge 1 commit intomainfrom
Open
Clear cache for any files that reference includes that are changed#470SanjulaGanepola wants to merge 1 commit intomainfrom
SanjulaGanepola wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
Member
Author
|
@worksofliam At a quick glance, is there any issues with clearing the cache in this scenario? |
Contributor
|
@SanjulaGanepola Have I understood your change correctly in that you only invalidate the cache for the changed include file and not for all includes? If you can confirm, I will test and review. I don't see any reason for not clearing the cache for changed includes - on the contrary! Cache programming is one of the hardest programming disciplines, and I think you're absolutely right here. |
Member
Author
|
@chrjorgensen Caching can indeed be tricky. Just so its clear, here is the updated flow:
The only part that is new with this PR is step 4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #465
Whenever include files are changed now, we clear the cache for any files that reference that include.
Before
after making some changes to the ILE Docs in
empdet.rpgleinc, the hover is not updated inempdet.sqlrpgle:After