Fix ZONED/PACKED/BINDEC decimal position ToolTip Fixes issue #480#478
Open
bobcozzi wants to merge 5 commits intocodefori:mainfrom
Open
Fix ZONED/PACKED/BINDEC decimal position ToolTip Fixes issue #480#478bobcozzi wants to merge 5 commits intocodefori:mainfrom
bobcozzi wants to merge 5 commits intocodefori:mainfrom
Conversation
- ZONED and PACKED now render with :0 when decimals are zero (e.g., ZONED(5:0) instead of ZONED(5:)) - BINDEC now omits :0 by convention (e.g., BINDEC(9) instead of BINDEC(9:0)) - BINDEC includes decimal positions when non-zero (e.g., BINDEC(9:3)) - Set default decimals to '0' instead of empty string in getPrettyType()
worksofliam
requested review from
chrjorgensen and
worksofliam
and removed request for
chrjorgensen
- Remove aggressive fallback logic that could show incorrect subfields - Rely on findDefinition() for proper scope/qualification awareness - Keep parent structure context display for correctly-found symbols - Improve correctness: show nothing instead of something wrong
Author
|
Was there anything else I need to change/fix in this PR to get it into the extension? |
…ensive tests - Fixed parseDLine() to correctly parse decimal positions (columns 41-42) - Updated getPrettyType() to always include decimals in BINDEC output - Added tests for both free-format and fixed-format BINDEC declarations - All 290 tests passing
bobcozzi
changed the title
bobcozzi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated the tooltip (hover text) that shows up for field definitions for Zoned and BinDec variables. Also added similar code to Packed Decimal although the issue was not directly observed for packed, I felt it was good measure to include it there as well.
Checklist
console.logs I added