Skip to content

[Enhancement] - Include versioning to frontend UI#282

Merged
leekahung merged 2 commits intomainfrom
implement-frontend-versioning
Feb 23, 2026
Merged

[Enhancement] - Include versioning to frontend UI#282
leekahung merged 2 commits intomainfrom
implement-frontend-versioning

Conversation

@leekahung
Copy link
Contributor

@leekahung leekahung commented Feb 22, 2026

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Infrastructure
  • Maintenance

Description

Related to PR #180, this PR implements UI to show versioning for the frontend UI. When the backend version is merged in, a follow-up PR could be made to include the version for our backend to help with versioning for Tenant First Aid.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note on the devices and browsers this has been tested on, as well as any relevant images for UI changes.

Screenshot 2026-02-22 at 12 24 40 AM Screenshot 2026-02-22 at 12 23 30 AM

Added/updated tests?

  • Yes
  • No, and this is why: Simple UI implementation for frontend versioning
  • I need help with writing tests

Documentation

  • If this PR changes the system architecture, Architecture.md has been updated

[optional] Are there any post deployment tasks we need to perform?

@leekahung leekahung requested a review from yangm2 February 22, 2026 08:30
@leekahung leekahung self-assigned this Feb 22, 2026
@leekahung leekahung added the frontend Frontend implementation (follows UX design) label Feb 22, 2026
@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2026

Claude finished @leekahung's task in 1m 18s —— View job


Code Review - PR #282: Frontend Versioning (Updated)

Tasks

  • Gather context and understand the PR
  • Read changed files
  • Verify previous feedback was addressed
  • Post review feedback

Summary

Both pieces of feedback from the previous review have been addressed. This is ready to merge.

__APP_VERSION__ in test environments — resolved

vitest.config.ts now imports version from package.json and defines the same define block as vite.config.ts:

import { version } from "./package.json";

export default defineConfig({
  define: {
    __APP_VERSION__: JSON.stringify(version),
  },
  // ...
});

This is the simplest correct fix. The version is read from package.json independently in both configs, which is fine — there's no meaningful duplication concern at this scale.

tsconfig.node.json — resolved

The vitest.config.ts addition to tsconfig.node.json is gone; the file is unchanged from main and only includes vite.config.ts as before.

Everything else looks good:

  • vite-env.d.ts has the correct declare const __APP_VERSION__: string so TypeScript is satisfied.
  • Footer placement in App.tsx (outside <Routes>, inside <Router>) renders correctly on every page.
  • package.json version bump from 0.0.00.1.0 is appropriate.
  • Mobile sidebar version display complements the desktop footer.

Copy link
Contributor

@yangm2 yangm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the backend version is in pyproject.toml. I guess we'd need a new backend endpoint so that the frontend could query the version from the backend. We'd also want to expose some of the deployment variables, not secrets, (like GOOGLE_DATASTORE_ID and MODEL_NAME).

@leekahung
Copy link
Contributor Author

LGTM - the backend version is in pyproject.toml. I guess we'd need a new backend endpoint so that the frontend could query the version from the backend. We'd also want to expose some of the deployment variables, not secrets, (like GOOGLE_DATASTORE_ID and MODEL_NAME).

That sounds good.

@leekahung leekahung merged commit 003f6ae into main Feb 23, 2026
7 checks passed
@leekahung leekahung deleted the implement-frontend-versioning branch February 23, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Frontend implementation (follows UX design)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants