Skip to content

fix: signal trait #9846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michalsn merged 1 commit into from
Dec 18, 2025
Merged

fix: signal trait #9846

michalsn merged 1 commit into from
Dec 18, 2025
+5 −1

Conversation

@michalsn
Copy link
Member

@michalsn michalsn commented Dec 18, 2025

Description
This PR fixes SignalTrait for Windows. When pcntl extension is not available, signal constants will be unrecognized, causing errors. See: codeigniter4/queue#71

No changelog entry is included, as SignalTrait is a new feature in 4.7.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added bug Verified issues on the current code behavior or pull requests that will fix them 4.7 labels Dec 18, 2025
@michalsn michalsn merged commit 53a4b41 into codeigniter4:4.7 Dec 18, 2025
49 checks passed
@michalsn
Copy link
Member Author

michalsn commented Dec 18, 2025

Thank you @paulbalandan

@michalsn michalsn deleted the fix/signals-windows branch December 18, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

4.7 bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michalsn @paulbalandan