Remove useless control-flow no-ops and enforce UCF SpotBugs rule

[shai-almog]

Motivation

• Silence SpotBugs "Useless control flow" (UCF) findings by removing no-op branches that do nothing but trigger UCF warnings.
• Keep behavior and semantics unchanged while removing empty or redundant branches across compression, service, and UI code.
• Also ensure the repository quality gate treats UCF findings as build failures so regressions are caught in CI.

Description

• Removed empty/no-op control-flow branches in several files including CodenameOne/src/com/codename1/io/gzip/Deflater.java, CodenameOne/src/com/codename1/io/gzip/Inflater.java, CodenameOne/src/com/codename1/io/gzip/ZStream.java, and CodenameOne/src/com/codename1/io/gzip/InfBlocks.java to eliminate UCF warnings.
• Cleaned up empty branches and redundant checks in UI and service code such as CodenameOne/src/com/codename1/io/services/TwitterRESTService.java, CodenameOne/src/com/codename1/ui/BrowserComponent.java, CodenameOne/src/com/codename1/ui/Label.java, CodenameOne/src/com/codename1/ui/LeadUtil.java, CodenameOne/src/com/codename1/ui/TextField.java, CodenameOne/src/com/codename1/ui/Toolbar.java, CodenameOne/src/com/codename1/ui/html/HTMLComponent.java, CodenameOne/src/com/codename1/ui/layouts/mig/CodenameOneMiGContainerWrapper.java, CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java, and CodenameOne/src/com/codename1/ui/spinner/DateTimeSpinner3D.java to remove no-op branches flagged by SpotBugs.
• Updated the quality gate script .github/scripts/generate-quality-report.py to add the SpotBugs rule "UCF_USELESS_CONTROL_FLOW" to the set of forbidden rules so such findings will fail the PR CI.

Testing

• No automated unit or integration tests were executed as part of this change (no mvn or test runs were performed).
• Changes are limited to removal of no-op branches and one rule addition in the quality-report script, intended to be semantically neutral.
• The CI quality gate will now fail if SpotBugs emits UCF_USELESS_CONTROL_FLOW findings for modified or other files.
• Manual compilation or CI validation is recommended to confirm there are no regressions in SpotBugs/compilation in the CI environment.

---

Codex Task

[shai-almog]

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

• BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

• graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

• graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

• graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

• graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
  Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

• graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

• kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 411 seconds
• Compilation Time: 97 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	44283 ms
Extract Extensions	47 ms
Google Services Setup	6 ms
Scan Classes	1627 ms
Extract Libs	2215 ms
Inject Build Hints	113 ms
Generate Unit Tests	8 ms
Generate Stubs	1836 ms
Compile Stubs	3484 ms
Generate Icons	1629 ms
Prepare ParparVM	257 ms
ParparVM Execution	233442 ms
Post-VM Setup	300 ms
CocoaPods	7320 ms
Finalize	50 ms
Total Time	296621 msMaven Overhead : 115000 ms
CocoaPods Install (Script)	2000 ms
Simulator Boot (Run)	70000 ms
App Install	16000 ms
App Launch	9000 ms
Test Execution	204000 ms

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2282 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.87% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
    • com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

• ❌ SpotBugs: 134 findings (Normal: 85, Low: 49) [HTML preview] [Download]
  • Top findings
    • Normal: CodenameOne/src/com/codename1/capture/Capture.java:262 – Naked notify in com.codename1.capture.Capture$CallBack.actionPerformed(ActionEvent) (rule: NN_NAKED_NOTIFY)
    • Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:489 – Integral division result cast to double or float in com.codename1.charts.ChartComponent.pointerDragged(int[], int[]) (rule: ICAST_IDIV_CAST_TO_DOUBLE)
    • Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:682 – Return value of com.codename1.charts.renderers.XYMultipleSeriesRenderer.isPanEnabled() ignored, but method has no side effect (rule: RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT)
    • Normal: CodenameOne/src/com/codename1/charts/ChartComponent.java:770 – Return value of com.codename1.charts.renderers.XYMultipleSeriesRenderer.isZoomEnabled() ignored, but method has no side effect (rule: RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT)
    • Normal: CodenameOne/src/com/codename1/charts/compat/Paint.java:38 – Unused field: com.codename1.charts.compat.Paint.g (rule: UUF_UNUSED_FIELD)
    • …and 129 more
• ❌ PMD: 2555 findings (P2: 1, P3: 486, P4: 2068) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1040 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/components/RSSReader.java:500 – Overriding method merely calls super (rule: UselessOverridingMethod)
    • P3: CodenameOne/src/com/codename1/facebook/Album.java:198 – Overriding method merely calls super (rule: UselessOverridingMethod)
    • P3: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:1312 – Unnecessary semicolon (rule: UnnecessarySemicolon)
    • …and 2550 more
• ❌ Checkstyle: 220871 findings (Warning: 220871) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 220866 more

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 30 screenshots: 30 matched.

Native Android coverage

• 📊 Line coverage: 24.56% (2632/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.11% (12182/50528), branch 14.96% (699/4672), complexity 17.26% (732/4241), method 32.53% (592/1820), class 33.66% (102/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

• 📊 Line coverage: 24.56% (2632/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 24.11% (12182/50528), branch 14.96% (699/4672), complexity 17.26% (732/4241), method 32.53% (592/1820), class 33.66% (102/303)
  • Lowest covered classes
    • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
    • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
    • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)