Fix tap-status-bar-to-scroll when global Toolbar is in use (#3589)#4814
Conversation
Toolbar.initTitleBarStatus created a plain Container as the StatusBar, ignoring statusBarScrollsUpBool. With the global Toolbar (the modern default), the iOS fake tap forwarded by cn1StatusBarTapProxy at (width/2, 0) landed on a non-clickable Container, so scroll-to-top never fired. Mirror Form.createStatusBar by creating a Button with the scroll-to-top listener when statusBarScrollsUpBool is true. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
|
Compared 37 screenshots: 37 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
Benchmark ResultsDetailed Performance Metrics
|
iOS screenshot updatesCompared 37 screenshots: 0 matched, 37 updated.
Benchmark Results
Build and Run Timing
Detailed Performance Metrics
|
The previous fix attempt ran into a compile error because Component.setSafeArea does not exist - setSafeArea is only defined on Container. Replacing the StatusBar Container with a Button (as #4814 did) therefore drops safe-area support entirely, which is what made 36 of 37 iOS screenshot baselines diverge. Keep the StatusBar as a Container (so setSafeArea(true) and the StatusBar UIID styling continue to apply unchanged), and attach a pointer-released listener to it for the scroll-to-top behavior #4814 introduced. The synthetic iOS tap forwarded by cn1StatusBarTapProxy still fires Component.pointerReleased, which dispatches to that listener. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…sion) (#4815) * Toolbar: restore setSafeArea on StatusBar button branch (#4814 regression) The fix in #4814 wrapped the StatusBar component creation in an if/else but only set setSafeArea(true) on the Container fallback. With the default statusBarScrollsUpBool=true the new Button branch ran without safe-area treatment, so the iOS top inset was no longer reserved and every form shifted vertically. iOS screenshot tests caught this: 36 of 37 baselines diverged on the merge commit. Move setSafeArea(true) below the if/else so it applies to both the Button and Container cases, matching the pre-#4814 behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Toolbar: keep StatusBar as a Container to preserve safeArea behavior The previous fix attempt ran into a compile error because Component.setSafeArea does not exist - setSafeArea is only defined on Container. Replacing the StatusBar Container with a Button (as #4814 did) therefore drops safe-area support entirely, which is what made 36 of 37 iOS screenshot baselines diverge. Keep the StatusBar as a Container (so setSafeArea(true) and the StatusBar UIID styling continue to apply unchanged), and attach a pointer-released listener to it for the scroll-to-top behavior #4814 introduced. The synthetic iOS tap forwarded by cn1StatusBarTapProxy still fires Component.pointerReleased, which dispatches to that listener. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Shai Almog <67850168+shai-almog@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 participants
Summary
Toolbarwas in use, even withpaintsTitleBarBoolandstatusBarScrollsUpBoolenabled.Toolbar.initTitleBarStatus()created a plainContaineras the StatusBar component and never honoredstatusBarScrollsUpBool. The iOS native shim (cn1StatusBarTapProxy) forwards a fake tap at(displayWidth/2, 0), but with noButtonto receive it, nothing scrolled.Form.createStatusBar(): whenstatusBarScrollsUpBoolis true (default), it creates aButtonwhose action listener callsfindScrollableChild(...)+scrollRectToVisible(...). When the constant is false, the legacy plain-Containerbehavior is preserved.Form.findScrollableChild(...)is package-private andToolbarshares the package.Test plan
paintsTitleBarBool: trueandstatusBarScrollsUpBool: true, default global Toolbar, scrollable content (≥ a screenful).statusBarScrollsUpBool: false: tap does not scroll, layout/sizing unchanged.Form.createStatusBar).🤖 Generated with Claude Code