Skip to content

Fixed icon localization issue in iOS#4827

Merged
shai-almog merged 1 commit into
masterfrom
icon-localization-ios-bug
Apr 29, 2026
Merged

Fixed icon localization issue in iOS#4827
shai-almog merged 1 commit into
masterfrom
icon-localization-ios-bug

Conversation

@shai-almog
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

  • AsciiDoc linter: No issues found (report)
  • Vale: 15073 alert(s) (1104 errors, 4453 warnings, 9516 suggestions) (exit code 1) (report)
  • Image references: No unused images detected (report)

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 29, 2026

Compared 34 screenshots: 34 matched.
✅ JavaScript-port screenshot tests passed.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Continuous Quality Report

Test & Coverage

Static Analysis

  • SpotBugs [Report archive]
    • ByteCodeTranslator: 0 findings (no issues)
    • android: 0 findings (no issues)
    • codenameone-maven-plugin: 0 findings (no issues)
    • core-unittests: 0 findings (no issues)
    • ios: 0 findings (no issues)
  • PMD: 0 findings (no issues) [Report archive]
  • Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 29, 2026

Android screenshot updates

Compared 65 screenshots: 64 matched, 1 error.

  • TabsTheme_dark — comparison error. Comparison error: PNG chunk truncated before CRC while processing: /home/runner/work/_temp/cn1ss-lkDsBg/TabsTheme_dark.png

    No preview available for this screenshot.
    Full-resolution PNG saved as TabsTheme_dark.png in workflow artifacts.

Native Android coverage

  • 📊 Line coverage: 8.67% (4639/53524 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 6.80% (22846/335748), branch 3.24% (1046/32302), complexity 4.03% (1246/30918), method 7.06% (1019/14432), class 11.61% (223/1920)
    • Lowest covered classes
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
      • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
      • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
      • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/730 lines covered)
      • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
      • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
      • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
      • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

Benchmark Results

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 1120.000 ms
Base64 CN1 encode 262.000 ms
Base64 encode ratio (CN1/native) 0.234x (76.6% faster)
Base64 native decode 798.000 ms
Base64 CN1 decode 295.000 ms
Base64 decode ratio (CN1/native) 0.370x (63.0% faster)
Image encode benchmark status skipped (SIMD unsupported)

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Apr 29, 2026

iOS screenshot updates

Compared 65 screenshots: 61 matched, 4 errors.

  • graphics-affine-scale — comparison error. Comparison error: PNG chunk truncated before CRC while processing: /Users/runner/work/_temp/cn1-ios-tests-qOLl5g/graphics-affine-scale.png

    No preview available for this screenshot.
    Full-resolution PNG saved as graphics-affine-scale.png in workflow artifacts.

  • graphics-draw-gradient — comparison error. Comparison error: PNG chunk truncated before CRC while processing: /Users/runner/work/_temp/cn1-ios-tests-qOLl5g/graphics-draw-gradient.png

    No preview available for this screenshot.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-fill-polygon — comparison error. Comparison error: PNG chunk truncated before CRC while processing: /Users/runner/work/_temp/cn1-ios-tests-qOLl5g/graphics-fill-polygon.png

    No preview available for this screenshot.
    Full-resolution PNG saved as graphics-fill-polygon.png in workflow artifacts.

  • graphics-fill-triangle — comparison error. Comparison error: PNG chunk truncated before CRC while processing: /Users/runner/work/_temp/cn1-ios-tests-qOLl5g/graphics-fill-triangle.png

    No preview available for this screenshot.
    Full-resolution PNG saved as graphics-fill-triangle.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 0 seconds
  • Compilation Time: 284 seconds

Build and Run Timing

Metric Duration
Simulator Boot 82000 ms
Simulator Boot (Run) 1000 ms
App Install 13000 ms
App Launch 9000 ms
Test Execution 246000 ms

Detailed Performance Metrics

Metric Duration
Base64 payload size 8192 bytes
Base64 benchmark iterations 6000
Base64 native encode 1786.000 ms
Base64 CN1 encode 2008.000 ms
Base64 encode ratio (CN1/native) 1.124x (12.4% slower)
Base64 native decode 1099.000 ms
Base64 CN1 decode 1240.000 ms
Base64 decode ratio (CN1/native) 1.128x (12.8% slower)
Base64 SIMD encode 503.000 ms
Base64 encode ratio (SIMD/native) 0.282x (71.8% faster)
Base64 encode ratio (SIMD/CN1) 0.250x (75.0% faster)
Base64 SIMD decode 530.000 ms
Base64 decode ratio (SIMD/native) 0.482x (51.8% faster)
Base64 decode ratio (SIMD/CN1) 0.427x (57.3% faster)
Image encode benchmark iterations 100
Image createMask (SIMD off) 90.000 ms
Image createMask (SIMD on) 14.000 ms
Image createMask ratio (SIMD on/off) 0.156x (84.4% faster)
Image applyMask (SIMD off) 270.000 ms
Image applyMask (SIMD on) 85.000 ms
Image applyMask ratio (SIMD on/off) 0.315x (68.5% faster)
Image modifyAlpha (SIMD off) 169.000 ms
Image modifyAlpha (SIMD on) 87.000 ms
Image modifyAlpha ratio (SIMD on/off) 0.515x (48.5% faster)
Image modifyAlpha removeColor (SIMD off) 239.000 ms
Image modifyAlpha removeColor (SIMD on) 126.000 ms
Image modifyAlpha removeColor ratio (SIMD on/off) 0.527x (47.3% faster)
Image PNG encode (SIMD off) 1510.000 ms
Image PNG encode (SIMD on) 1193.000 ms
Image PNG encode ratio (SIMD on/off) 0.790x (21.0% faster)
Image JPEG encode 748.000 ms

@shai-almog shai-almog merged commit 3238c1b into master Apr 29, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant