CI: collapse ios-packaging matrix to a single both-managers job#4839
Merged
Conversation
The pods-only and spm-only matrix entries are proper subsets of the both entry, which exercises CocoaPods AND Swift Package Manager in a single Xcode project. Each dependency manager pathway runs end to end in the both configuration, so dropping the two narrower entries loses no real coverage but cuts the workflow from 3 sequential macOS jobs (~130 min wall clock when the runner queue is saturated) to one (~35 min). The native iOS notification tests step was previously gated to the both entry only; with a single job remaining the conditional is removed and the step always runs. Job renamed from packaging-matrix to packaging since there's no matrix anymore. Artifact name simplified from ios-packaging-<entry> to ios-packaging. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pods-onlyandspm-onlymatrix entries inios-packaging.ymlare proper subsets of thebothentry, which exercises CocoaPods and Swift Package Manager in a single Xcode project. Each dependency manager pathway runs end-to-end in thebothconfiguration, so dropping the two narrower entries loses no real coverage.This cuts the workflow from 3 sequential macOS jobs (~130 min wall-clock when the runner queue is saturated) down to 1 job (~35 min).
Changes
bothconfig'sIOS_DEPENDENCY_ARGSdirectly on the job.packaging-matrixtopackaging.if: matrix.packaging.name == 'both'guard on the native iOS notification tests step — with a single config it always runs.ios-packaging-<entry>toios-packaging.Coverage analysis
pod install, pod-only Xcode project)pods-only+bothbothspm-only+bothbothbothbothbothThe only thing strictly lost: a hypothetical bug that fires only when the other dependency manager is absent (e.g., something that breaks when no Podfile is present). That's a niche failure mode for a project that supports both managers; if it ever bites, scripts-ios.yml (which builds with no extra deps) would catch the no-Podfile-no-SPM variant.
Expected savings
Test plan
yaml.safe_load).dependencyManager=both.both).ios-packaging.🤖 Generated with Claude Code