Refresh Skin Designer device database#4862
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
automation
dependencies
github-actions
Bot
force-pushed
the
automation/skin-designer-device-db
branch
from
29e3a9c to
645de65
Compare
Contributor
Author
Cloudflare Preview
|
5 tasks
shai-almog
added a commit
that referenced
this pull request
May 5, 2026
The scheduled trickle scrape has been hitting a 404 since #4758 landed (latest-mobiles.php3 doesn't exist on GSMArena), so every 6h run pulled zero phones and only opened PRs because the JSON envelope churned between runs (e.g. #4862). Replace the trickle path with a weekly run of the verified per-brand walk, and make the script skip writing the file when no device records actually change so envelope drift can't spam PRs again. - Workflow: weekly Mon 03:00 UTC, single brands scrape, 75m timeout (cold cache). Drop the mode dispatch input and trickle/full split. - Script: drop dead --mode latest path (walk_latest, RE_LATEST_LINK, --mode flag). Add _devices_changed() so the file is only rewritten when actual records added/removed/modified, ignoring envelope diffs. - README: document the new weekly cadence. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/skindesigner/common/src/main/resources/devices.jsonby scraping a small batch of the latest devices from GSMArena and
merging into the existing catalog.
Created automatically by the Skin Designer device DB workflow.